Isolate more features #6854
Merged
Isolate more features #6854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…contributions; make groupings the same
…erwidget contribution into their respective files
# Conflicts: # src/sql/workbench/parts/dataExplorer/browser/dataExplorer.contribution.ts # src/sql/workbench/parts/query/browser/queryActions.ts
# Conflicts: # src/sql/workbench/common/actions.contribution.ts # src/sql/workbench/common/actions.ts # src/sql/workbench/parts/dashboard/browser/widgets/explorer/explorerWidget.common.contribution.ts # src/sql/workbench/parts/dataExplorer/common/nodeActions.common.contribution.ts # src/sql/workbench/parts/objectExplorer/browser/serverTreeActionProvider.ts # src/sql/workbench/parts/query/browser/query.contribution.ts
anthonydresser
requested review from
abist,
Charles-Gagnon,
aaomidi and
kburtram
abist
reviewed
Aug 21, 2019
| import 'sql/workbench/parts/dataExplorer/common/extensions.contribution'; | ||
|
|
||
| //restore | ||
| import 'sql/workbench/parts/restore/browser/restore.contribution'; |
There was a problem hiding this comment.
is there a reason we are leaving out the other contributions?
abist
approved these changes
Aug 21, 2019
Charles-Gagnon
requested changes
Aug 22, 2019
added 4 commits
August 22, 2019 12:31
# Conflicts: # extensions/integration-tests/src/objectExplorer.test.ts
|
@Charles-Gagnon i fixed the tests for this pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Isolates backup/restore/notebooks and extension entry points to their own contribution files