OE clicking and awaiting the expansion calls #6761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/sql/workbench/parts/objectExplorer/browser/treeSelectionHandler.ts
Outdated
Show resolved
Hide resolved
| } | ||
| this._lastClicked = specificSelection; | ||
| this._lastClicked = selection; | ||
| } | ||
|
|
||
| this._clickTimer = setTimeout(() => { |
There was a problem hiding this comment.
Does it make more sense to just move the setTiemout to the if mouse event since for other selection types (keyboard) we don't want to use this timeout method?
There was a problem hiding this comment.
Hmm yeah. Do we want to treat a keyboard selection as a full double click?
| } | ||
| this._lastClicked = specificSelection; | ||
| this._lastClicked = selection; | ||
| } | ||
|
|
||
| this._clickTimer = setTimeout(() => { |
There was a problem hiding this comment.
vscode also has a class for wrapping timeouts, https://github.com/microsoft/azuredatastudio/blob/master/src/vs/base/common/async.ts#L496 if you want to use it.
There was a problem hiding this comment.
Oo this looks good!
anthonydresser
approved these changes
Aug 20, 2019
kevcunnane
pushed a commit
that referenced
this pull request
Aug 22, 2019
aaomidi
added a commit
that referenced
this pull request
Aug 22, 2019
aaomidi
added a commit
that referenced
this pull request
Aug 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this we call the expand/refresh/expandAll codepoints without awaiting their response. This was causing random issues and race conditions with our code depending on how fast you clicked.