Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alanren/welcomepage #6537

Merged
merged 3 commits into from
Jul 30, 2019
Merged

Alanren/welcomepage #6537

merged 3 commits into from
Jul 30, 2019

Conversation

alanrenmsft
Copy link
Contributor

remove the dependency on vs/platform/product/node/product

anthonydresser
anthonydresser approved these changes Jul 30, 2019
View reviewed changes
Copy link
Contributor

@anthonydresser anthonydresser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shift the carbon edits to be inline with the actual edit and this looks good.

@alanrenmsft alanrenmsft merged commit f68ed67 into master Jul 30, 2019
@alanrenmsft alanrenmsft deleted the alanren/welcomepage branch July 30, 2019 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Charles-Gagnon Charles-Gagnon Charles-Gagnon approved these changes

@anthonydresser anthonydresser anthonydresser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alanrenmsft @anthonydresser @Charles-Gagnon