Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some differences from us and vscode #6421

Merged
merged 2 commits into from
Jul 19, 2019
Merged

Remove some differences from us and vscode #6421

merged 2 commits into from
Jul 19, 2019

Conversation

anthonydresser
Copy link
Contributor

Some of these I think were lost when we did the revert of the merge earlier in the month. Some of these were just deleting files that got added.

@anthonydresser anthonydresser requested a review from kburtram July 18, 2019 20:56
Charles-Gagnon
Charles-Gagnon approved these changes Jul 18, 2019
View reviewed changes
Copy link
Contributor

@Charles-Gagnon Charles-Gagnon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@anthonydresser anthonydresser merged commit bf4815d into master Jul 19, 2019
@anthonydresser anthonydresser deleted the engineering/removedifferences branch July 19, 2019 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Charles-Gagnon Charles-Gagnon Charles-Gagnon approved these changes

@kburtram kburtram kburtram approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anthonydresser @kburtram @Charles-Gagnon