Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EXTERNAL and FIRST_ROW to the keyword list for colorizing #6097

Merged
merged 1 commit into from
Jun 19, 2019

Conversation

Charles-Gagnon
Copy link
Contributor

Fixes #3453 - this was already mostly fixed by a SqlParser update but the colorizing still wasn't being done.

@Charles-Gagnon Charles-Gagnon requested a review from kburtram June 19, 2019 00:58
@Charles-Gagnon
Copy link
Contributor Author

Charles-Gagnon commented Jun 19, 2019

Note this has been updated on the vscode-mssql extension already with microsoft/vscode-mssql@a79741f (along with a couple other keywords that were updated in ADS but not there)

@Charles-Gagnon Charles-Gagnon merged commit fab8de6 into master Jun 19, 2019
@Charles-Gagnon Charles-Gagnon deleted the chgagnon/updateIntellisenseColorsList branch June 19, 2019 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New SQL 2019 syntax shows as error in Query editor
2 participants