Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to force reload extensions #5990

Merged
merged 1 commit into from
Jun 11, 2019
Merged

Added option to force reload extensions #5990

merged 1 commit into from
Jun 11, 2019

Conversation

abist
Copy link
Contributor

@abist abist commented Jun 11, 2019

Added the ability to force extensions to reload, with CMS being the first extension to use this.

Fixes #5889 and #5846

@abist abist requested a review from kburtram June 11, 2019 22:11
@Charles-Gagnon
Copy link
Contributor

public canAddExtension(extension: IExtensionDescription): boolean {

Did you verify that this method isn't being used in different ways? The name seems a little generic for being something that we want for a specific purpose.


Refers to: src/vs/workbench/services/extensions/electron-browser/extensionService.ts:299 in 84ed6d7. [](commit_id = 84ed6d7, deletion_comment = False)

@abist
Copy link
Contributor Author

abist commented Jun 11, 2019

@Charles-Gagnon Yes, we went over this before the last release. That function is only used to check whether an extension needs a reload or not.

Copy link
Member

@kburtram kburtram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense to have this a generic option since other extensions will likely have a similar need. For example, I think Postgres probably should also use this setting. The correct long-term fix is to invalidate our various caches when an extension is installed. But this is a much simpler mid-term mitigation.

@Charles-Gagnon
Copy link
Contributor

@akamath46297 - Note that you may wish to leverage this functionality for the PG extension to solve the issues around the provider not showing up until a reload

@abist abist merged commit a03507c into master Jun 11, 2019
@abist abist deleted the cms/extensionReload branch June 11, 2019 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability for extensions to reload
3 participants