Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Merge from vscode 81d7885dc2e9dc617e1522697a2966bc4025a45d" #5983

Merged
merged 1 commit into from
Jun 11, 2019

Conversation

kburtram
Copy link
Member

Reverts #5949

The previous vs code merge is causing problems launch ADS under a debugger. We should roll-back until the issue is resolved. I'm testing the revert locally to confirm it resolves the issue prior to merging.

@kburtram
Copy link
Member Author

Here is the issue I'm seeing #5984

@kburtram
Copy link
Member Author

I confirmed this fixes #5984.

@kburtram kburtram merged commit 5a7562a into master Jun 11, 2019
@kburtram kburtram deleted the revert-5949-ads-master-vscode-2019-06-09T06-12-58 branch June 11, 2019 19:36
@kburtram
Copy link
Member Author

@alanrenmsft @chlafreniere we should root cause #5984 before resubmitting this merge. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant