#4418: Notebook file icon doesn't show for new notebook #4676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajmusuku
requested review from
kevcunnane,
corivera,
chlafreniere and
YurongHe
chlafreniere
approved these changes
Mar 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Core issue is, untitledModel gets loaded after we open editor, since we are resolving untitledEditorModel in notebook's model.
Made code changes to resolve model before opening the editor which would give us an opportunity to perform all the actions that are needed part of editor configuration. Took decent amount of time to trouble shoot it right through tabsTitleControl, icon and label classes.