More server properties fixes #24366
Merged
More server properties fixes #24366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
barbaravaldez
commented
Sep 11, 2023
barbaravaldez
commented
- Add locks validations: server properties locks (parallelism) cannot be negative #24316
- Disable scan startup procs and locks properties for Sql MI: Disable Scan Startup Procs and Locks properties for MI #24365
- Only notify user to restart server if they apply changes.
barbaravaldez
changed the title
corivera
approved these changes
Sep 11, 2023
| @@ -514,10 +517,16 @@ export class ServerPropertiesDialog extends ObjectManagementDialogBase<Server, S | |||
| ], true); | |||
|
|
|||
| const radioLoginsGroupName = 'serverLoginsRadioGroup'; | |||
| const isWindows = this.objectInfo.platform === 'Windows'; | |||
There was a problem hiding this comment.
Is there a constant we can use instead of the string literal here?
barbaravaldez
added a commit
that referenced
this pull request
Sep 12, 2023
* fix locks min value * disable login auditing in linux * disable some properties from advanced tab
kisantia
pushed a commit
that referenced
this pull request
Sep 12, 2023
siyao-Siyang
pushed a commit
that referenced
this pull request
Oct 12, 2023
* fix locks min value * disable login auditing in linux * disable some properties from advanced tab
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.