Clean up typings file #23200
Clean up typings file #23200
Conversation
|
Ah, that explains it. Seems like VS Code added doc comment validation to the hygiene. Easy enough to fix. @lewis-sanchez @kburtram This should have had a SQL CARBON TODO, right? Let's make sure we're tracking follow up items like this during merges so we can get back to a clean state afterwards. |
|
For full context, this isn't anything to do with VS Code at all. A long time back I added the check-param-names rule to our sql linting and that's what was failing here Now the real question is why did it just start failing during the merge....and I don't have a good answer for that. I looked around briefly to see what might have changed, but didn't see anything obvious. And it's good to have this kind of stuff so I'm not going to bother investigating further at this point. |
| @@ -89,7 +89,9 @@ module.exports.indentationFilter = [ | |||
| '!test/monaco/out/**', | |||
| '!test/smoke/out/**', | |||
| '!extensions/typescript-language-features/test-workspace/**', | |||
| '!extensions/typescript-language-features/resources/walkthroughs/**', | |||
There was a problem hiding this comment.
Ordering alphabetically and cleaning this up a bit - I did this when I thought it was a hygiene error and it's helpful to keep things in this file organized.
Linting from latest DT update. No idea why these eslint-disables were added in the last merge....