Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Append Endpoint suffix to storage blob connection string #22704

Merged
merged 1 commit into from
Apr 13, 2023
Merged

Append Endpoint suffix to storage blob connection string #22704

merged 1 commit into from
Apr 13, 2023

Conversation

cheenamalhotra
Copy link
Member

Fixes publish issues due to missing endpoint suffix.
Verified connection string from Azure Portal for storage account, validated with local testing.

Charles-Gagnon
Charles-Gagnon approved these changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@Charles-Gagnon Charles-Gagnon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did something change recently to require this?

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4683447869

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.002%) to 41.674%
Files with Coverage Reduction New Missed Lines %
extensions/sql-bindings/src/common/azureFunctionsUtils.ts 1 80.65%
extensions/sql-database-projects/src/common/httpClient.ts 1 66.18%
extensions/sql-database-projects/src/dialogs/publishDatabaseDialog.ts 2 50.74%
Totals Coverage Status
Change from base Build 4683268486: 0.002%
Covered Lines: 30328
Relevant Lines: 67383
💛 - Coveralls

@cheenamalhotra
Copy link
Member Author

Did something change recently to require this?

Yep we recently migrated from old azure-storage npm package in PR #22664

@cheenamalhotra cheenamalhotra merged commit 728f70b into main Apr 13, 2023
@cheenamalhotra cheenamalhotra deleted the cheena/endpoint-suffix branch April 13, 2023 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Charles-Gagnon Charles-Gagnon Charles-Gagnon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cheenamalhotra @coveralls @Charles-Gagnon