-
Notifications
You must be signed in to change notification settings - Fork 910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade xml2js to v0.5.0 + migration to @vscode/vsce + migration to @azure/storage-blob #22664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cssuh
previously approved these changes
Apr 10, 2023
Pull Request Test Coverage Report for Build 4672453351
💛 - Coveralls |
cheenamalhotra
force-pushed
the
cheena/fix-xml2js
branch
from
April 10, 2023 23:32
ac10d52
to
8a6df18
Compare
cheenamalhotra
force-pushed
the
cheena/fix-xml2js
branch
from
April 11, 2023 00:49
9043dca
to
33cf1da
Compare
Are you done making changes? If not, could you put this in a draft state until it's ready for review? |
cheenamalhotra
dismissed
cssuh’s stale review
April 11, 2023 17:12
Not relevant anymore with the new changes.
cheenamalhotra
changed the title
Upgrade xml2js to v0.5.0
Upgrade xml2js to v0.5.0 + migration to @vscode/vsce + migration to @azure/storage-blob
Apr 11, 2023
Charles-Gagnon
approved these changes
Apr 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert unnecessary changes to VS Code stuff, otherwise looks good. Thanks for taking the time to clean this up!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consuming dependencies:
extensions.ts
with code from VSCode reporsitory in code paths that are not SQL Carbon edited, to make sure we're calling the APIs in the right way..build\external\extensions\***
don't containyarn.lock
and therefore when callingvsce.createVSIX
,useYarn
is set tofalse
to fix the error during packaging extensions (error log)https://www.npmjs.com/package/@vscode/vsce (update not available - Not tracked as of now, as it requires additional changes reverted in commit)