Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade xml2js to v0.5.0 + migration to @vscode/vsce + migration to @azure/storage-blob #22664

Merged
merged 13 commits into from
Apr 11, 2023

Conversation

cheenamalhotra
Copy link
Member

@cheenamalhotra cheenamalhotra commented Apr 10, 2023

Consuming dependencies:

cssuh
cssuh previously approved these changes Apr 10, 2023
@coveralls
Copy link

coveralls commented Apr 10, 2023

Pull Request Test Coverage Report for Build 4672453351

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 158 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.009%) to 41.7%

Files with Coverage Reduction New Missed Lines %
extensions/notebook/src/dialog/configurePython/configurePathPage.ts 1 57.02%
extensions/machine-learning/src/common/processService.ts 2 81.48%
src/sql/workbench/contrib/objectExplorer/browser/serverTreeView.ts 155 17.26%
Totals Coverage Status
Change from base Build 4662200904: 0.009%
Covered Lines: 30360
Relevant Lines: 67415

💛 - Coveralls

@Charles-Gagnon
Copy link
Contributor

Are you done making changes? If not, could you put this in a draft state until it's ready for review?

@cheenamalhotra cheenamalhotra marked this pull request as draft April 11, 2023 17:11
@cheenamalhotra cheenamalhotra dismissed cssuh’s stale review April 11, 2023 17:12

Not relevant anymore with the new changes.

@cheenamalhotra cheenamalhotra changed the title Upgrade xml2js to v0.5.0 Upgrade xml2js to v0.5.0 + migration to @vscode/vsce + migration to @azure/storage-blob Apr 11, 2023
@cheenamalhotra cheenamalhotra marked this pull request as ready for review April 11, 2023 20:36
build/lib/extensions.ts Show resolved Hide resolved
extensions/dart/package.json Show resolved Hide resolved
extensions/julia/package.json Show resolved Hide resolved
Copy link
Contributor

@Charles-Gagnon Charles-Gagnon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert unnecessary changes to VS Code stuff, otherwise looks good. Thanks for taking the time to clean this up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants