Add datavirtualization extension #21594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 3924469877
💛 - Coveralls |
aasimkhan30
approved these changes
Jan 15, 2023
| "CentOS_7": "linux-x64.tar.gz", | ||
| "Debian_8": "linux-x64.tar.gz", | ||
| "Fedora_23": "linux-x64.tar.gz", | ||
| "OpenSUSE_13_2": "linux-x64.tar.gz", |
There was a problem hiding this comment.
Didn't know that these platforms were supported.I should add this to import extension as well.
There was a problem hiding this comment.
You don't need to - the linux config in the import extension will cover all the various Linux distros. I plan on changing this to something similar as one of my follow up tasks.
There was a problem hiding this comment.
@aasimkhan30 remember that I've explained to you about this? you only need to specify a specific configuration it needs to use a different build. :)
alanrenmsft
approved these changes
Jan 17, 2023
|
Follow up tasks : #21603 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving from other repo to make this easier to maintain. This was originally started by an issue updating to the new telemetry package which required the extension to be webpacked - and in doing that I decided just to do the work and move it here since it's always been annoying to deal with it being in the other repo and there's no reason to not have it public now.
The backing service will stay in the other repo for now, although at some point I'd like to move that into the STS repo or somewhere similar too.
Mostly a direct copy/paste, but there's a lot of cleanup I did (such as removing most of the package dependencies since they weren't actually being used anymore).
Tests currently aren't running, and there's likely runtime issues but I'm getting this first PR in so that follow up PRs to fix the other things can be more targeted and easily reviewed.