Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Announcing nav info when user enter ep and removing F3 shortcut to show/hide tooltip. #21004

Merged
merged 1 commit into from
Oct 27, 2022
Merged

Announcing nav info when user enter ep and removing F3 shortcut to show/hide tooltip. #21004

merged 1 commit into from
Oct 27, 2022

Conversation

aasimkhan30
Copy link
Contributor

  1. Navigation info announcement when user enter graph
    Issue: A11y_Azure Data Studio_Query Plan (Preview)_ScreenReader: NVDA not announcing navigation key information at each node #20778
    This is pattern is very commonly used in vscode to let users know important key shortcut. I am adding the navigation information to the graph so it gets announced whenever the focus enters an execution plan.

Vscode example:
image

<textarea class="xterm-helper-textarea" aria-label="Terminal 2, powershell
Use Ctrl+UpArrow and Ctrl+DownArrow to navigate the terminal buffer" aria-multiline="false" autocorrect="off" autocapitalize="off" spellcheck="false" tabindex="0" style="left: 115.2px; top: 180px; width: 7.2px; height: 18px; line-height: 18px; z-index: -5;"></textarea>
  1. Allowing users to expand/collapse button
  2. Tooltips shown only when enter is pressed on the node. Hover based tooltips are disabled by default. This also
    addressing the issue A11y_Azure Data Studio_Query Plan (Preview)_ScreenReader: NVDA is not announcing tooltip present at any node. #20765. Now tooltips are only announced if the user clicks or press enter on the focused node.

Demo:
azuredatastudio_4bMrcVnFux

@aasimkhan30
Fixes:
a71e337 
1. Navigation info announcement when user enter graph
2. Allowing users to expand/collapse button
3. Tooltips shown only when enter is pressed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3333674000

  • 0 of 5 (0.0%) changed or added relevant lines in 2 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.008%) to 41.928%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/sql/workbench/contrib/executionPlan/browser/executionPlanView.ts 0 2 0.0%
src/sql/workbench/contrib/executionPlan/browser/azdataGraphView.ts 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
extensions/notebook/src/common/ports.ts 4 74.14%
Totals Coverage Status
Change from base Build 3333374096: -0.008%
Covered Lines: 28861
Relevant Lines: 63931
💛 - Coveralls

@aasimkhan30 aasimkhan30 merged commit 1743c7e into main Oct 27, 2022
@aasimkhan30 aasimkhan30 deleted the aasim/fix/20778 branch October 27, 2022 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kburtram kburtram kburtram approved these changes

@lewis-sanchez lewis-sanchez Awaiting requested review from lewis-sanchez

@Charles-Gagnon Charles-Gagnon Awaiting requested review from Charles-Gagnon

@alanrenmsft alanrenmsft Awaiting requested review from alanrenmsft

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aasimkhan30 @coveralls @kburtram