Fix cell navigation #19082
Merged
Fix cell navigation #19082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2164436966
💛 - Coveralls |
Charles-Gagnon
approved these changes
Apr 14, 2022
VasuBhog
approved these changes
Apr 14, 2022
barbaravaldez
added a commit
that referenced
this pull request
Apr 14, 2022
chlafreniere
pushed a commit
that referenced
this pull request
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After introducing the fix for tab navigation through cells, we focus on the selected cell and we need to update the condition to take that into account.
When clicking, tabbing, and moving the active element in the document is the cell. However when we hit escape to exit edit mode the focus is lost and we need the original check
DOM.isAncestor(this.container.nativeElement, document.activeElement)Also, when moving to another cell we need to focus on the new active cell, so the focus doesn't stay in the previous cell.
This pr is for #19058