Enable cell cancellation for Interactive notebooks #19005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2157622165
💛 - Coveralls |
Charles-Gagnon
approved these changes
Apr 12, 2022
barbaravaldez
approved these changes
Apr 12, 2022
corivera
added a commit
that referenced
this pull request
Apr 13, 2022
* Also added a check to prevent multiple Interactive cells from executing simultaneously.
chlafreniere
pushed a commit
that referenced
this pull request
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main change here is the implementation of the interrupt() method in VSCodeKernel. A bunch of the other changes are related to URI usage in this code path. I changed the URI fields in IExecuteRequest to be strings like the other URI fields in our extension APIs. The actual URI object wasn't being deserialized properly over RPC, so if you tried to call toString() on that object it would return the generic Object string. So now anytime we need to use the actual URI we call URI.parse() on that string. A lot of areas were already using a string representation anyway, like getDocument() in ExtHostNotebookDocumentsAndEditors.
Fixes #18979