Adding badge icons to execution plan #19004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/sql/workbench/contrib/executionPlan/browser/executionPlan.ts
Outdated
Show resolved
Hide resolved
src/sql/workbench/contrib/executionPlan/browser/executionPlan.ts
Outdated
Show resolved
Hide resolved
Pull Request Test Coverage Report for Build 2151060000
💛 - Coveralls |
lewis-sanchez
approved these changes
Apr 11, 2022
Charles-Gagnon
approved these changes
Apr 11, 2022
src/sql/workbench/contrib/executionPlan/browser/executionPlan.ts
Outdated
Show resolved
Hide resolved
src/sql/workbench/contrib/executionPlan/browser/executionPlan.ts
Outdated
Show resolved
Hide resolved
| tooltip: string | ||
| } { | ||
| /** | ||
| * TODO: Need to figure out if tooltip have to be removed. For now, they are empty |
There was a problem hiding this comment.
If you're not using this then just remove it until you actually determine you need it.
alanrenmsft
reviewed
Apr 11, 2022
alanrenmsft
approved these changes
Apr 11, 2022
kburtram
approved these changes
Apr 11, 2022
aasimkhan30
added a commit
that referenced
this pull request
Apr 12, 2022
* Adding badge icons to executionplan * Fixing doc comment * Fixing doc comments * Making enum value more readable * Changing default to undefined. * Fixing some icon names
kburtram
pushed a commit
that referenced
this pull request
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes: #18879
Issue to track TODO: #19003