Fix new table issue #18974
Merged
Fix new table issue #18974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 7, 2022 17:44
caohai
approved these changes
Apr 8, 2022
Pull Request Test Coverage Report for Build 2116437966
💛 - Coveralls |
alanrenmsft
reviewed
Apr 8, 2022
src/sql/workbench/browser/editor/tableDesigner/tableDesignerInput.ts
Outdated
Show resolved
Hide resolved
| this._tableIcon = tableInfo.tableIcon.toString() === '' ? TableIcon.Basic : tableInfo.tableIcon as TableIcon; | ||
|
|
||
| // default to basic if icon is null (new table) or no sub type | ||
| this._tableIcon = tableInfo.tableIcon ? tableInfo.tableIcon as TableIcon : TableIcon.Basic; |
There was a problem hiding this comment.
This should still be able to be simplified even further to this._tableIcon = tableInfo.tableIcon || TableIcon.Basic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #18960
Explicitly check for null or empty string for icons (didn't exist for Folder type node)