Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add markdown smoke tests for changing text size and inserting links #18888

Merged
merged 15 commits into from
Apr 5, 2022
Merged

Add markdown smoke tests for changing text size and inserting links #18888

merged 15 commits into from
Apr 5, 2022

Conversation

corivera
Copy link
Member

No description provided.

@corivera corivera requested a review from a team March 30, 2022 23:51
@coveralls
Copy link

coveralls commented Mar 31, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2098526469

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 390 unchanged lines in 8 files lost coverage.
  • Overall coverage increased (+0.01%) to 42.381%
Files with Coverage Reduction New Missed Lines %
extensions/sql-database-projects/src/models/project.ts 6 94.7%
src/sql/base/query/browser/untitledQueryEditorInput.ts 10 22.22%
extensions/sql-bindings/src/dialogs/addSqlBindingQuickpick.ts 15 67.42%
src/sql/workbench/services/queryEditor/browser/queryEditorService.ts 17 53.25%
extensions/sql-bindings/src/common/azureFunctionsUtils.ts 29 26.74%
extensions/sql-bindings/src/services/azureFunctionsService.ts 43 10.43%
extensions/sql-database-projects/src/controllers/projectController.ts 115 41.84%
src/sql/workbench/browser/modelComponents/table.component.ts 155 11.96%
Totals Coverage Status
Change from base Build 2078693600: 0.01%
Covered Lines: 27572
Relevant Lines: 60822
💛 - Coveralls

@corivera
Copy link
Member Author

corivera commented Apr 5, 2022

Build failure isn't related to any of my changes, so I'll go ahead and merge it.

@corivera corivera merged commit 7c399e8 into main Apr 5, 2022
@corivera corivera deleted the corivera/moreToolbarTests branch April 5, 2022 22:53
corivera added a commit that referenced this pull request Apr 6, 2022
@corivera
Add markdown smoke tests for changing text size and inserting links (#…
af3b94a 
…18888)

* Temporarily disabled text size tests due to issues running on Unix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Charles-Gagnon Charles-Gagnon Charles-Gagnon approved these changes

@lucyzhang929 lucyzhang929 lucyzhang929 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@corivera @coveralls @lucyzhang929 @Charles-Gagnon