Haven't gone through this all - but at first glance I'm seeing a lot of Azure resource stuff here, including creating an Azure server. We shouldn't be having common function like that in here - it should live in a place that's usable by other features as well.

We have azurecore in ADS for that - so the work here then should be more about getting what you need implemented in VS Code in a similar way (or finding an existing extension that does this, such as the VS Code Azure extension) and then using one of those to do any operations against Azure resources.

I agree having a shared place would be useful for other extensions. vacode-mssql extension might be the right place for this. I tried using Azure core which didn't work because of the way we authenticate to Azure using mssql-vscode extension.

Haven't gone through this all - but at first glance I'm seeing a lot of Azure resource stuff here, including creating an Azure server. We shouldn't be having common function like that in here - it should live in a place that's usable by other features as well.

We have azurecore in ADS for that - so the work here then should be more about getting what you need implemented in VS Code in a similar way (or finding an existing extension that does this, such as the VS Code Azure extension) and then using one of those to do any operations against Azure resources.

@Charles-Gagnon and @kisantia I moved the Azure API to mssql extension in this PR: microsoft/vscode-mssql#17321 please review that PR first and after it's approved, I'll update this PR so it calls the APIs using mssql extension

Haven't gone through this all - but at first glance I'm seeing a lot of Azure resource stuff here, including creating an Azure server. We shouldn't be having common function like that in here - it should live in a place that's usable by other features as well.
We have azurecore in ADS for that - so the work here then should be more about getting what you need implemented in VS Code in a similar way (or finding an existing extension that does this, such as the VS Code Azure extension) and then using one of those to do any operations against Azure resources.

@Charles-Gagnon and @kisantia I moved the Azure API to mssql extension in this PR: microsoft/vscode-mssql#17321 please review that PR first and after it's approved, I'll update this PR so it calls the APIs using mssql extension

@Charles-Gagnon @kisantia the change in mssql extension is checked in and applied in this PR. please continue with the review. Thanks

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ llali sign now
_{You have signed the CLA already but the status is still pending? Let us recheck it.}