Create shared access signature RPC #18823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
March 24, 2022 11:15
nemanja-milovancevic
requested review from
Charles-Gagnon,
alanrenmsft,
Benjin and
kisantia
as code owners
Charles-Gagnon
requested changes
Mar 25, 2022
Pull Request Test Coverage Report for Build 2202984950
💛 - Coveralls |
src/sql/workbench/services/azureBlob/browser/azureBlobService.ts
Outdated
Show resolved
Hide resolved
Charles-Gagnon
approved these changes
Apr 6, 2022
|
Alright, everything here looks good but let's finish up the STS PR and get that in so that we can also update STS in this PR (since this depends on the STS changes to function) |
raghavthind2005
approved these changes
Apr 18, 2022
|
@caohai FYI, this is bringing in microsoft/sqltoolsservice#1467 |
alanrenmsft
approved these changes
Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the createSas method to the backup provider. It's needed for creating a shared access signature for the backup/restore blob container.
This method should be used when the user wants to back up the database to the URL or restore it from the URL. A shared access signature is an expiring secret string that can be used to store something on a blob container. After creating SAS, it should be stored in the MSSQL sys.credential table. Method createSas does these two things: it creates SAS and stores it in sys.credentials.
The parameters are:
You can see the flow here:
From the UI point of view, this is the RPC that's going to be called when the user clicks Create Credentials button on the URL browser dialog:
