Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to langpack versions #17910

Merged
merged 2 commits into from
Dec 14, 2021
Merged

Bump to langpack versions #17910

merged 2 commits into from
Dec 14, 2021

Conversation

smartguest
Copy link
Contributor

This should have been implemented with this change #17904 but it was missed, this will need to be ported to the 1.34 release branch as well, otherwise the new langpacks won't be properly generated

Copy link
Contributor

@Charles-Gagnon Charles-Gagnon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow up with making sure that the process for updating these langpacks is documented with all the relevant steps (such as this one).

@smartguest
Copy link
Contributor Author

@Charles-Gagnon they have been documented, just that this was a bit rushed due to the deadline. I'll highlight the relevant section.

@smartguest smartguest merged commit 02310b9 into main Dec 14, 2021
@smartguest smartguest deleted the alex/fixforlangpackversions branch December 14, 2021 17:45
smartguest added a commit that referenced this pull request Dec 14, 2021
* Bump to langpack versions

* fixed newline
@coveralls
Copy link

coveralls commented Dec 14, 2021

Pull Request Test Coverage Report for Build 1579138843

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 41.686%

Totals Coverage Status
Change from base Build 1574879361: 0.0%
Covered Lines: 27294
Relevant Lines: 59393

💛 - Coveralls

kburtram pushed a commit that referenced this pull request Dec 14, 2021
* Bump to langpack versions

* fixed newline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants