Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update to langpack source files for October release #17374

Merged
merged 1 commit into from
Oct 15, 2021
Merged

update to langpack source files for October release #17374

merged 1 commit into from
Oct 15, 2021

Conversation

smartguest
Copy link
Contributor

Adds new strings for the October release

Charles-Gagnon
Charles-Gagnon approved these changes Oct 15, 2021
View reviewed changes
Copy link
Contributor

@Charles-Gagnon Charles-Gagnon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future would you be able to combine the xlf and json updates into one? Would be nice not to have to sign off on multiple of these each time.

@smartguest
Copy link
Contributor Author

@Charles-Gagnon Yeah I can, just thought it would be overwhelming, but I'll take that into account next time

@smartguest smartguest merged commit 59b43d8 into main Oct 15, 2021
@smartguest smartguest deleted the alex/updatetolangpacksourcefiles10-15-2021 branch October 15, 2021 20:32
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1347341115

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 41.472%
Totals Coverage Status
Change from base Build 1347293808: 0.0%
Covered Lines: 26802
Relevant Lines: 58623
💛 - Coveralls

languy pushed a commit to languy/azuredatastudio that referenced this pull request Nov 17, 2021
@smartguest @languy
update to langpack source files (microsoft#17374)
72f9641
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Charles-Gagnon Charles-Gagnon Charles-Gagnon approved these changes

@kburtram kburtram Awaiting requested review from kburtram

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smartguest @coveralls @Charles-Gagnon