Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update smoke test repo #15101

Merged
merged 1 commit into from
Apr 13, 2021
Merged

Update smoke test repo #15101

merged 1 commit into from
Apr 13, 2021

Conversation

@alanrenmsft
Copy link
Contributor

Did I miss something last week? could you please share some context ?

@Charles-Gagnon
Copy link
Contributor Author

I've just been slowly moving over repos that our team uses that are currently in people's private accounts into the official MS org. We can't/shouldn't be using private repos like this.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 742564793

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.006%) to 43.546%

Files with Coverage Reduction New Missed Lines %
extensions/import/src/wizard/pages/fileConfigPage.ts 1 73.46%
extensions/notebook/src/common/ports.ts 4 74.14%
Totals Coverage Status
Change from base Build 742463039: -0.006%
Covered Lines: 26179
Relevant Lines: 54937

💛 - Coveralls

Copy link
Member

@kburtram kburtram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. But I think the CI builds are failing.

@Charles-Gagnon
Copy link
Contributor Author

That was just the Notebook integration tests that Lucy and Vasu are working on fixing right now, all the others passed.

@Charles-Gagnon Charles-Gagnon merged commit 0ce57eb into main Apr 13, 2021
@Charles-Gagnon Charles-Gagnon deleted the chgagnon/updateSmokeTestRepo branch April 13, 2021 20:54
JustinMDotNet pushed a commit that referenced this pull request Apr 15, 2021
Charles-Gagnon added a commit that referenced this pull request Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants