Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for language packs, #14912

Merged
merged 44 commits into from
Mar 31, 2021
Merged

Update for language packs, #14912

merged 44 commits into from
Mar 31, 2021

Conversation

smartguest
Copy link
Contributor

Code for the language packs are based on recent vscode language packs. Renamed the language pack folders to be more consistent with vscode and updated with more recent ADS SQL and extension strings.

smartguest added 30 commits March 1, 2021 14:40
@smartguest
update DE lang pack extension strings from previous refresh
6a71315
@smartguest
bump lang pack versions for DE
e4f362f
@smartguest
update for spanish langpack
ccc7c6a
@smartguest
update for french langpack
2330ea8
@smartguest
update for italian pack
c278e11
@smartguest
update for japanese pack
967e947
@smartguest
update for korean pack
3cfe8ae
@smartguest
update for Brazilian Portuguese pack
34ebb1f
@smartguest
update for Russian pack
c20db41
@smartguest
Update for Simplified Chinese pack
a336d07
@smartguest
update for Traditional Chinese pack
caf1f9b
@smartguest
added updated language packs for german and spanish
5ad9ab5
@smartguest
changed vscode version
da4bc23
@smartguest
added french and italian packs
b518cbd
@smartguest
changes made to main
9ba21f2
@smartguest
japanese language pack added
8ef1372
@smartguest
added korean pack
f013f68
@smartguest
Added Portuguese pack
9756f7f
@smartguest
added russian pack, also small change to pt pack
bfb6b91
@smartguest
simplified chinese pack
e3647e6
@smartguest
added traditional chinese pack
1ce1088
@smartguest
deleted old language packs
dd352d0
@smartguest
restore sql.i18n.json files
fbfe626
@smartguest
Main.i18n.json reverted
362a593
@smartguest
Revert sql json files
cf32663
@smartguest
main.i18n.json file for German updated
7a5b946
@smartguest
updates to language packs 1
88d60b4
@smartguest
main json for italian updated.
2fcaf26
@smartguest
update to japanese main
9dc46f3
@smartguest
finished translations for vs and sql in main.
10818b3
kburtram
kburtram approved these changes Mar 30, 2021
View reviewed changes
Copy link
Member

@kburtram kburtram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a bunch of files that we likely don't need, like for java and c++ extensions. Should we remove those files before merging?

@coveralls
Copy link

coveralls commented Mar 30, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 705726930

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 388 unchanged lines in 9 files lost coverage.
  • Overall coverage decreased (-0.05%) to 43.152%
Files with Coverage Reduction New Missed Lines %
extensions/sql-database-projects/src/models/project.ts 1 95.47%
extensions/notebook/src/common/utils.ts 5 85.57%
extensions/sql-database-projects/src/projectProvider/projectProvider.ts 16 18.18%
extensions/notebook/src/book/bookModel.ts 17 77.27%
extensions/notebook/src/book/bookVersionHandler.ts 27 61.9%
extensions/sql-database-projects/src/dialogs/addDatabaseReferenceDialog.ts 36 60.72%
extensions/notebook/src/book/bookTocManager.ts 39 73.12%
extensions/notebook/src/book/bookTreeView.ts 82 44.55%
extensions/sql-database-projects/src/controllers/projectController.ts 165 55.0%
Totals Coverage Status
Change from base Build 702286333: -0.05%
Covered Lines: 25531
Relevant Lines: 53995
💛 - Coveralls

@smartguest smartguest merged commit f7b9ca7 into main Mar 31, 2021
@smartguest smartguest deleted the alex/updatefordelanguagepack branch March 31, 2021 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Charles-Gagnon Charles-Gagnon Charles-Gagnon approved these changes

@kburtram kburtram kburtram approved these changes

@khoiph1 khoiph1 Awaiting requested review from khoiph1

@alanrenmsft alanrenmsft Awaiting requested review from alanrenmsft

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@smartguest @coveralls @kburtram @Charles-Gagnon