Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pick up Electron 1.7.12 #1291

Merged
merged 3 commits into from
Apr 30, 2018
Merged

Pick up Electron 1.7.12 #1291

merged 3 commits into from
Apr 30, 2018

Conversation

kburtram
Copy link
Member

@kburtram kburtram commented Apr 27, 2018 •
edited
Loading

VS Code already updated to 1.7.12 in master. We might as well pick this up since we may not merge their code again for another month or so.

I noticed 1.7.13 is already out so might as go to that version. The delta with 1.7.12 looks minimal.

@kburtram kburtram changed the title Pick up Electron 1.7.12 Pick up Electron 1.7.13 Apr 28, 2018
@anthonydresser
Copy link
Contributor

vscode updated to 1.7.13 and then reverted it microsoft/vscode@b0793e6#diff-a3e03be55c12fe638fe1e1c5aa684b9a might be some problem with 1.7.13

@kburtram kburtram changed the title Pick up Electron 1.7.13 Pick up Electron 1.7.12 Apr 30, 2018
@kburtram
Copy link
Member Author

@anthonydresser thanks for checking. I'll go back to 1.7.12 to match VS Code.

@kburtram kburtram merged commit 55e3947 into master Apr 30, 2018
@kburtram kburtram deleted the feature/bumpElectron branch April 30, 2018 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattIrv MattIrv Awaiting requested review from MattIrv

@anthonydresser anthonydresser Awaiting requested review from anthonydresser

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kburtram @anthonydresser