Fix checkbox change event not firing on enter press #12703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanrenmsft
approved these changes
Oct 1, 2020
alanrenmsft
reviewed
Oct 1, 2020
| @@ -48,6 +48,7 @@ export class Checkbox extends Widget { | |||
| this.onkeydown(this._el, e => { | |||
| if (e.equals(KeyCode.Enter)) { | |||
| this.checked = !this.checked; | |||
| this._onChange.fire(this.checked); | |||
There was a problem hiding this comment.
checkbox should also handle Space key, while you are on this file, do you mind adding space key here?
There was a problem hiding this comment.
That's already handled by the base component. If I'm remembering this correctly the reason we do this stuff here is because we want to purposely stop the propagation so that it doesn't go up and get caught by the wizard page (which would do the "OK" action).
But anyways verified that both enter and space work.
Pull Request Test Coverage Report for Build 283255128
💛 - Coveralls |
Charles-Gagnon
added a commit
that referenced
this pull request
Oct 5, 2020
* Fix checkbox change event not firing * Add comment
kburtram
pushed a commit
that referenced
this pull request
Oct 5, 2020
halerankin
pushed a commit
that referenced
this pull request
Oct 13, 2020
* Fix checkbox change event not firing * Add comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The key handler was stopping the event from propagating so we never got the onchange event - which was then breaking the model view stuff since the extension side would never get its property value updated.