Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme links and changelog after release #12681

Merged
merged 1 commit into from
Sep 30, 2020
Merged

Conversation

abist
Copy link
Contributor

@abist abist commented Sep 30, 2020

Changelog and readme update after release publishing

[linux-zip]: https://go.microsoft.com/fwlink/?linkid=2142212
[linux-rpm]: https://go.microsoft.com/fwlink/?linkid=2142213
[linux-deb]: https://go.microsoft.com/fwlink/?linkid=2142214
[win-user]: https://go.microsoft.com/fwlink/?linkid=2144429
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there shouldn't be new fwlinks for a hotfix release. the main point of the fwlinks is they always point to the latest release for the month.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know about this and made new fwlinks for this release. Should we still go ahead with it since it's published? I'll put down this as a note in the OneNote for future hotfixes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should probably still update the old fwlinks as well

@coveralls
Copy link

Pull Request Test Coverage Report for Build 280830401

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.007%) to 39.625%

Files with Coverage Reduction New Missed Lines %
extensions/notebook/src/common/ports.ts 4 74.14%
Totals Coverage Status
Change from base Build 280725472: -0.007%
Covered Lines: 19919
Relevant Lines: 45937

💛 - Coveralls

@abist abist merged commit 0583e1d into main Sep 30, 2020
@abist abist deleted the updates/hotfix-1.22.1 branch September 30, 2020 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants