Fix root group name check #12660
Merged
Fix root group name check #12660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abist
approved these changes
Sep 29, 2020
Pull Request Test Coverage Report for Build 278925094
💛 - Coveralls |
Charles-Gagnon
added a commit
that referenced
this pull request
Oct 5, 2020
kburtram
pushed a commit
that referenced
this pull request
Oct 5, 2020
smartguest
pushed a commit
that referenced
this pull request
Oct 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12587 - casing shouldn't matter for the root group name. Group names aren't case sensitive so users can't add their own groups named root so this is safe.