GenerateToNotebook and Deploy buttons for Notebook Wizards #12656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Charles-Gagnon
requested changes
Sep 29, 2020
extensions/resource-deployment/src/ui/notebookWizard/notebookWizard.ts
Outdated
Show resolved
Hide resolved
ranasaria
requested review from
alanrenmsft,
aasimkhan30,
abist and
chlafreniere
and removed request for
abist
alanrenmsft
reviewed
Sep 29, 2020
Charles-Gagnon
approved these changes
Sep 29, 2020
| taskName?: string; | ||
| type?: DeploymentType; | ||
| actionText?: string; | ||
| /** | ||
| * done button attributes. |
There was a problem hiding this comment.
I do not see the extra space.
| pages: NotebookWizardPageInfo[] | ||
| } | ||
|
|
||
| export interface WizardInfoBase extends FieldInfoBase { | ||
| /** | ||
| * the taskName to use when running the notebook as a background task. The default value is the @see title of the wizard. |
There was a problem hiding this comment.
We can get rid of this now right?
There was a problem hiding this comment.
Will check to ensure none of subclasses are using it.
smartguest
pushed a commit
that referenced
this pull request
Oct 5, 2020
* enable userChooses how to run notebook * arc ext changes * nb fixes * working version * revert unneeded changes * fix comments * Update interfaces.ts * fix comments * fix comments * fix comments * runAllCells instead of background execute * pr feedback * PR feedback * pr feedback * arc ext changes for new WizardInfo syntax * fix doc comments * pr feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a feature to support both ScriptToNotebook and Deploy buttons in a Notebook Wizard. The Deploy button now runs the notebook instead of executing the notebook using azdata in a new process.
Testing:
This PR fixes #12577