Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the tests out to their own tasks #11179

Merged
merged 11 commits into from
Jul 3, 2020
Merged

Move the tests out to their own tasks #11179

merged 11 commits into from
Jul 3, 2020

Conversation

aaomidi
Copy link
Contributor

@aaomidi aaomidi commented Jul 2, 2020

@aaomidi aaomidi marked this pull request as draft July 2, 2020 06:43
@coveralls
Copy link

coveralls commented Jul 2, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 36.004% when pulling 2e62604 on amir/separateTests into fd29e35 on main.

Charles-Gagnon
Charles-Gagnon reviewed Jul 2, 2020
View reviewed changes
Copy link
Contributor

@Charles-Gagnon Charles-Gagnon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should do this for ci builds too

build/azure-pipelines/linux/sql-product-build-linux.yml Outdated Show resolved Hide resolved
@aaomidi aaomidi marked this pull request as ready for review July 3, 2020 00:17
@aaomidi aaomidi requested a review from Charles-Gagnon July 3, 2020 00:17
Charles-Gagnon
Charles-Gagnon approved these changes Jul 3, 2020
View reviewed changes
Copy link
Contributor

@Charles-Gagnon Charles-Gagnon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't want to do this for ci pipeline as well?

@aaomidi
Copy link
Contributor Author

aaomidi commented Jul 3, 2020 •
edited
Loading

Which one? We have so many now :D @Charles-Gagnon

@Charles-Gagnon
Copy link
Contributor

But only one with the honor to have the actual name ci.yml 😉

https://github.com/microsoft/azuredatastudio/blob/main/.github/workflows/ci.yml

@aaomidi
Copy link
Contributor Author

aaomidi commented Jul 3, 2020

Oh, since that's not ADO i'll handle that later.

@aaomidi aaomidi merged commit 2d989e1 into main Jul 3, 2020
@aaomidi aaomidi deleted the amir/separateTests branch July 3, 2020 00:51
smartguest pushed a commit that referenced this pull request Jul 20, 2020
@smartguest
Move the tests out to their own tasks (#11179)
f4ddc5d 
* Move the tests out to their own tasks

* Revert change

* Lets try this

* Actually reference to the tests

* Lets try this

* lets try this too?

* this one?

* Manually define them :(

* Formatting

* Add the node command

* Fix machine learning and address comments
chlafreniere pushed a commit that referenced this pull request Jul 28, 2020
@chlafreniere
Move the tests out to their own tasks (#11179)
b72dab3 
* Move the tests out to their own tasks

* Revert change

* Lets try this

* Actually reference to the tests

* Lets try this

* lets try this too?

* this one?

* Manually define them :(

* Formatting

* Add the node command

* Fix machine learning and address comments
ktech99 pushed a commit that referenced this pull request Aug 23, 2020
@ktech99
Move the tests out to their own tasks (#11179)
9476d51 
* Move the tests out to their own tasks

* Revert change

* Lets try this

* Actually reference to the tests

* Lets try this

* lets try this too?

* this one?

* Manually define them :(

* Formatting

* Add the node command

* Fix machine learning and address comments
@SakshiS-harma SakshiS-harma mentioned this pull request Dec 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Charles-Gagnon Charles-Gagnon Charles-Gagnon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aaomidi @coveralls @Charles-Gagnon