removing datasource from publish dialog for insiders #11009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kisantia
approved these changes
Jun 18, 2020
Benjin
approved these changes
Jun 19, 2020
| @@ -92,10 +93,11 @@ export class DeployDatabaseDialog { | |||
| { | |||
| title: constants.targetDatabaseSettings, | |||
| components: [ | |||
| /* TODO : enable using this when data source creation is enabled | |||
There was a problem hiding this comment.
With this removal, does connectionIsDataSource need to be explicitly set to false (rather than undefined)?
There was a problem hiding this comment.
The two places its checked for 1) enable deploy/script button 2) chose connection to create - both checking undefined so it works. Let me know if you still feel I should change it (closing this PR but can do in the other open PR.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes # #10983 for this insiders with minimal change. Will re-enable post insiders for further work. Validated with all enabled/disabled tests