Initial work on Arc tree view #11008
Conversation
extensions/arc/src/common/utils.ts
Outdated
| } else if (error instanceof Error) { | ||
| } else if (error.message) { | ||
| if (error.response?.statusMessage) { | ||
| // Some Http errors just have a status message as additional detail, but it's not |
There was a problem hiding this comment.
Are there words missing at the end of this comment?
| private _controllerNodes: ControllerTreeNode[] = []; | ||
|
|
||
| constructor(private _context: vscode.ExtensionContext) { | ||
| // TODO: |
There was a problem hiding this comment.
What is to be done here? I assume it's related to the 5 second delay.
There was a problem hiding this comment.
Load the persisted controllers (one-time action done upon creation)
There was a problem hiding this comment.
(I didn't bother to write context here since I'm fixing that right now myself)
|
|
||
| public async openDashboard(): Promise<void> { | ||
| const miaaDashboard = new MiaaDashboard(this._controllerModel, this._model); | ||
| await Promise.all([ |
There was a problem hiding this comment.
Should the controller model be refreshed here too?
There was a problem hiding this comment.
Possibly - I was thinking about it but I wasn't sure if that was necessary since in order for the node to show up it'd have to have been refreshed already.
I need to do a pass through through of correctly handling stuff being stale so this will likely be a part of that.
* Initial work on Arc tree view * finish my thoughts
~75% done but wanted to get this out before it got too large. Will follow up with further missing features and fixes.
Implemented :
Yet to do: