Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cp for coverage copy #11006

Merged
merged 4 commits into from
Jun 19, 2020
Merged

Use cp for coverage copy #11006

merged 4 commits into from
Jun 19, 2020

Conversation

anthonydresser
Copy link
Contributor

This PR fixes #

@coveralls
Copy link

coveralls commented Jun 18, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 35.155% when pulling d2dcbe1 on pipelines/copyCoverage into dc751db on main.

@anthonydresser anthonydresser marked this pull request as ready for review June 19, 2020 07:09
@anthonydresser
Copy link
Contributor Author

@Charles-Gagnon does the output of this look right? from what I can tell it looks like the same as current builds.

Charles-Gagnon
Charles-Gagnon approved these changes Jun 19, 2020
View reviewed changes
Copy link
Contributor

@Charles-Gagnon Charles-Gagnon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, everything looks the same. Thanks!

@anthonydresser anthonydresser changed the title test cp Use cp for coverage copy Jun 19, 2020
@anthonydresser anthonydresser merged commit a971aee into main Jun 19, 2020
@anthonydresser anthonydresser deleted the pipelines/copyCoverage branch June 19, 2020 17:07
ktech99 pushed a commit that referenced this pull request Aug 23, 2020
@ktech99
Use cp for coverage copy (#11006)
628d7e7 
* test cp

* mkdir

* maintain directory

* copy with directories
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Charles-Gagnon Charles-Gagnon Charles-Gagnon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anthonydresser @coveralls @Charles-Gagnon