Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove add database reference from command palette #11003

Merged
merged 1 commit into from
Jun 18, 2020

Conversation

kisantia
Copy link
Contributor

This PR fixes #10972. Add database reference should only be launched from the Database Reference node in a project, not from command palette.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 35.077% when pulling d311a20 on kisantia/removeFromCommandPallete into dc751db on main.

Copy link
Contributor

@alanrenmsft alanrenmsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this the only command you need to hide from command palette for this extension?

@kisantia
Copy link
Contributor Author

@alanrenmsft a bunch of other commands for this extension are already hidden. This was the only one that was showing in the command palette that needs to be hidden.

@kisantia kisantia merged commit 935733d into main Jun 18, 2020
@kisantia kisantia deleted the kisantia/removeFromCommandPallete branch June 18, 2020 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Database ref command from Pallet - should show or give user friendly error
4 participants