Hook up deletion for MIAA #10991
Merged
Hook up deletion for MIAA #10991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergeron
approved these changes
Jun 17, 2020
bergeron
reviewed
Jun 18, 2020
| }); | ||
| inputBox.onDidHide(() => { | ||
| if (!valueAccepted) { | ||
| resolve(false); |
There was a problem hiding this comment.
Does the inputBox need to be disposed in this case too?
bergeron
reviewed
Jun 18, 2020
| inputBox.placeholder = name; | ||
| return new Promise(resolve => { | ||
| let valueAccepted = false; | ||
| inputBox.show(); |
There was a problem hiding this comment.
Should it setup the onDid callbacks before showing the input box? They could type really fast and submit before the callbacks are setup.
There was a problem hiding this comment.
D'oh, missed seeing these before hitting submit. I'll get them in another PR.
ktech99
pushed a commit
that referenced
this pull request
Aug 23, 2020
* Hook up deletion for MIAA * fix button disabling * cannot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hooking up the deletion button for MIAA and updating PG and MIAA to use the same deletion request prompt.
Also improved the error message when an HttpError occurs since the default message wasn't very useful (would just say HTTP request failed)