Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account value was never set in the this context #10965

Merged
merged 1 commit into from
Jun 17, 2020

Conversation

aaomidi
Copy link
Contributor

@aaomidi aaomidi commented Jun 17, 2020

This PR fixes #10962

@aaomidi
Copy link
Contributor Author

aaomidi commented Jun 17, 2020

I'm not even sure how this worked before this.

Copy link
Contributor

@Charles-Gagnon Charles-Gagnon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests for this would be great give that it's broken multiple times now

@aaomidi
Copy link
Contributor Author

aaomidi commented Jun 17, 2020

The code is currently not testable really in its current state, but I'll try to do some cleanup to make it more testable.

@Charles-Gagnon
Copy link
Contributor

Yeah, that can be a follow-up task since there's questions like how much to mock out too. For example in this case we probably wouldn't be hitting the issue unless we actually had the Azure account node be the one triggering the command. So that might take some work to get in a testable state.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.007%) to 35.031% when pulling e53eea8 on amir/azureAuth/accountValue into 487bd26 on main.

@aaomidi aaomidi merged commit 8b68d52 into main Jun 17, 2020
@Charles-Gagnon Charles-Gagnon deleted the amir/azureAuth/accountValue branch July 23, 2020 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error filtering subscriptions
3 participants