Load profile support for sql project deploy #10948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benjin
approved these changes
Jun 17, 2020
|
|
||
| if (this.readPublishProfile) { | ||
| const result = await this.readPublishProfile(fileUris[0]); | ||
| (<azdata.InputBoxComponent>this.targetDatabaseTextBox).value = result.databaseName; |
There was a problem hiding this comment.
is it possible that no db name is there? and in this that case can we keep showing the proj name?
There was a problem hiding this comment.
Yup in that case, the name will become empty since that's what SSDT does.
| let targetDbName: string = ''; | ||
| let targetDatabaseNameCount = profileXmlDoc.documentElement.getElementsByTagName(constants.targetDatabaseName).length; | ||
| if (targetDatabaseNameCount > 0) { | ||
| // if there is more than one TargetDatabaseName nodes, SSDT uses the name in the last one so we'll do the same here |
There was a problem hiding this comment.
hmm.. good catch. Why are more than one db names allowed in SSDT?
There was a problem hiding this comment.
Not sure. It's pretty strange :/
udeeshagautam
approved these changes
Jun 19, 2020
ktech99
pushed a commit
that referenced
this pull request
Aug 23, 2020
* load database name from profile.xml * load sqlcmd variables from profile * Add warning text * add tests * fix file filter for windows * add comments * show SQLCMD variables in a table * reset dialog before testing readPublishProfile callback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #10924. This adds support for reading database name and SQLCMD variables from a publish profile. Support for other profile options will be added in later PRs.
Empty state (no profile loaded and no sqlcmdvars in the sqlproj):
This also fixes #10947 so that the values of SQLCMD variables show and change if the profile has different values for them (support for editing them in the UI will come later).
