Fix open notebook bug #10930
Merged
Fix open notebook bug #10930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Charles-Gagnon
requested review from
MaddyDev,
corivera,
barbaravaldez and
chlafreniere
Charles-Gagnon
commented
Jun 16, 2020
| filters: filter | ||
| }); | ||
| if (file && file.length > 0) { | ||
| await azdata.nb.showNotebookDocument(file[0]); |
There was a problem hiding this comment.
This is the fix. Instead of calling openTextDocument (which was known to be broken in the last vs code merge) just call the API we have already.
MaddyDev
approved these changes
Jun 16, 2020
corivera
reviewed
Jun 16, 2020
| } | ||
| } | ||
| } | ||
|
|
corivera
approved these changes
Jun 16, 2020
ktech99
pushed a commit
that referenced
this pull request
Aug 23, 2020
* Fix open notebook bug * cleanup * clean up spaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And adds a test for it. Fixes #10929
Moved some other tests around while I was working on this too to places that made more sense.