Initial unit tests for class NotebookEditor #10926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranasaria
requested review from
kburtram,
MaddyDev,
corivera,
Charles-Gagnon,
chlafreniere and
SakshiS-harma
Charles-Gagnon
approved these changes
Jun 15, 2020
corivera
approved these changes
Jun 15, 2020
chlafreniere
approved these changes
Jun 15, 2020
ktech99
pushed a commit
that referenced
this pull request
Aug 23, 2020
* first few notebookEditor tests * formating fixes * PR feedback * PR feedback * copyright fixes * improve test names and assertion messages * PR feedback * improve test names. * test name change * test name change * remove unneeded cast * remove spurious comment * fix misplaced paranthesis - thanks hygiene checker! * remove unused code * remove deferredPromise * rempve unnecessary mock usage in dispose test * use getContainer for ['parent'] * notebookService needs 9th constructor argument * Add uploading debugging step * remove changes to ci.yml Co-authored-by: Arvind Ranasaria MacPro <arvranmac@MININT-OE7B592.fareast.corp.microsoft.com> Co-authored-by: chgagnon <chgagnon@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request takes over the review from:#10879 - the branch corresponding to that PR is being left behind for Charles to do some code coverage trace upload diagnostics, so I am moving that PR to a new branch. If you had shared any feedback on the old PR then that has already been addressed and if you have new feedback, you can take care of it here or there. But final approvals should be done on this PR.
This PR checks in the initial few unit tests for NotebookEditor class. It also fixes a small stack overflow issue in promise.ts and does some spelling fixes and readability renames.
This PR fixes #10875
Tested all unit tests on a dev box. The following is the coverage added to the NotebookEditor class(from basically 0) from these tests:
https://user-images.githubusercontent.com/41588310/84447547-225fca00-abfd-11ea-9e8c-9a42a4eca7e7.png