Fix for auto resize column headers, #10909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into alex/fixforautoresizecolumnheaders
…soft/azuredatastudio into alex/fixforautoresizecolumnheaders
aaomidi
reviewed
Jun 16, 2020
| @@ -482,6 +482,7 @@ export abstract class GridTableBase<T> extends Disposable implements IView { | |||
| this.table.registerPlugin(new AdditionalKeyBindings()); | |||
| this._register(this.table.onContextMenu(this.contextMenu, this)); | |||
| this._register(this.table.onClick(this.onTableClick, this)); | |||
| this._register(this.table.onHeaderClick(this.onHeaderClick, this)); | |||
There was a problem hiding this comment.
It might help adding a comment on this line of what this listener is responsible for.
aaomidi
approved these changes
Jun 16, 2020
ktech99
pushed a commit
that referenced
this pull request
Aug 23, 2020
* Fixed scroll to top * removed brackets * Don't trigger the cellSelectionModel when className is the resizable handler * Added message for header listener Co-authored-by: Amir Omidi <amomidi@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scrolling issue has been fixed by me while Amir made changes to the cell selection plugin so that it no longer triggers when clicking on the resizable handler, allowing header clicking to function properly. When combined, these two fixes address the issue of scrolling and auto resize for results grid.
This PR fixes ##2251