Column/Table Drag & Drop #10702
Merged
Column/Table Drag & Drop #10702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaomidi
reviewed
Jun 8, 2020
abist
reviewed
Jun 8, 2020
aaomidi
reviewed
Jun 8, 2020
aaomidi
reviewed
Jun 8, 2020
abist
reviewed
Jun 9, 2020
abist
reviewed
Jun 10, 2020
abist
suggested changes
Jun 10, 2020
src/sql/workbench/services/objectExplorer/browser/dragAndDropController.ts
Outdated
Show resolved
Hide resolved
|
Sync'd offline and changes might be right, will investigate and get back in day. |
abist
reviewed
Jun 11, 2020
src/sql/workbench/services/objectExplorer/browser/treeCreationUtils.ts
Outdated
Show resolved
Hide resolved
abist
reviewed
Jun 11, 2020
abist
reviewed
Jun 11, 2020
abist
reviewed
Jun 11, 2020
abist
approved these changes
Jun 12, 2020
(wait for all the checks to pass first)
|
agreed, although it looks like I may need to add a test so the code coverage doesn't decrease |
abist
reviewed
Jun 12, 2020
src/sql/workbench/services/objectExplorer/browser/dragAndDropController.ts
Outdated
Show resolved
Hide resolved
aaomidi
reviewed
Jun 16, 2020
| TreeUpdateUtils.isInDragAndDrop = true; | ||
| const data = dragAndDropData.getData(); | ||
| const element = data[0]; | ||
| if (element.nodeTypeId === 'Column' || element.nodeTypeId === 'Table') { |
There was a problem hiding this comment.
i see you're referencing this in two parts of the code, would it make sense for this to be an enum? Or some sort of helper method
ktech99
pushed a commit
that referenced
this pull request
Aug 23, 2020
* able to drag objects from left pane * changed scheme from file * base functionality working * extended functionality to tables * added string literals and formatting * cleanup * cleanup * added table/column parsing * removed bad logic * updated to use metadata * cleanup and added sql carbon edit tags * moved changes from vs into sql code base * refactoring drag and drop * cleanup * cleanup * cleanup * added unit tests * pr changes * moved treeMock file * fixed small bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the base functionality for drag/drop in ADS. The purpose of this PR is to get some technical feedback on the implementation of this feature and suggestions on how I can improve it (I wanted to do this before I got too far along in the development).
Here is my current TODO list:
add parsing for the column label so it is correctly formattedAdd SQL Carbon Edit tags in the VS Code changesFuture enhancements (not meant to be included in this PR):
This PR fixes #3630