Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable sql-database-projects tests #10675

Merged
merged 1 commit into from
Jun 2, 2020

Conversation

Charles-Gagnon
Copy link
Contributor

@Charles-Gagnon Charles-Gagnon commented Jun 2, 2020

Temporary until we can figure out what's causing these test timeouts

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.8%) to 34.134% when pulling 28e111a on chgagnon/disableSqlProjTests into 0ac6a07 on master.

@Benjin
Copy link
Contributor

Benjin commented Jun 2, 2020

Another thing to try could be to reorder the test execution order to see whether it's still timing out at the database project tests.

@Charles-Gagnon
Copy link
Contributor Author

I'd rather just do this since we don't know for sure and this fails our product builds when it happens. We can always run the coverage/tests locally still to get numbers and verification when adding new tests so this isn't a huge deal not to run this in the lab builds for the time being IMO.

@Charles-Gagnon Charles-Gagnon merged commit 453f7fa into master Jun 2, 2020
@Charles-Gagnon Charles-Gagnon deleted the chgagnon/disableSqlProjTests branch June 2, 2020 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants