Add integration-test code coverage #10632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # extensions/integration-tests/package.json # extensions/mssql/yarn.lock
# Conflicts: # extensions/machine-learning/package.json
chlafreniere
approved these changes
May 29, 2020
| @@ -2,6 +2,186 @@ | |||
| # yarn lockfile v1 | |||
|
|
|||
|
|
|||
| "@babel/code-frame@^7.10.1": | |||
There was a problem hiding this comment.
why are there so many differences in this yarn.lock file
There was a problem hiding this comment.
So for some reason the yarn.lock was referencing the 1.0.5 version of vscodetestcover - which was before my big refactor to use the istanbul libs directly. So these changes are from all that
| @@ -6,7 +6,7 @@ | |||
| import 'mocha'; | |||
| import * as vscode from 'vscode'; | |||
| import * as azdata from 'azdata'; | |||
| import * as mssql from '../../../mssql'; | |||
| import * as mssql from '../../../mssql/src/mssql'; | |||
There was a problem hiding this comment.
can you explain this change a bit
There was a problem hiding this comment.
This was just being more explicit with the path - but it doesn't need to change (I was changing other things and just didn't revert this). I'll change it back.
corivera
approved these changes
Jun 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will be following up with adding a way to merge all the coverage reports together for a comprehensive coverage report.
Moved tests under test directory to keep in line with the test folder structure we use across the rest of the product.