Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sql project build on mac #10485

Merged
merged 2 commits into from
May 19, 2020
Merged

Fix sql project build on mac #10485

merged 2 commits into from
May 19, 2020

Conversation

kisantia
Copy link
Contributor

Sql proj build previously wasn't working on mac because some reference assemblies couldn't be found. This PR fixes #10464.

Copy link
Contributor

@udeeshagautam udeeshagautam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great other than the conditional add part! Thanks Kim for Fixing!

@coveralls
Copy link

coveralls commented May 18, 2020

Coverage Status

Coverage remained the same at 33.875% when pulling d1d7108 on kisantia/fixMacProjectTemplate into 283ffd7 on master.

@kisantia kisantia merged commit c98eaaf into master May 19, 2020
@kisantia kisantia deleted the kisantia/fixMacProjectTemplate branch May 19, 2020 00:08
@SakshiS-harma
Copy link
Contributor

Verified that it fixes similar error on Windows as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build on mac fails even after .net core sdk is installed
4 participants