Fix DE Icons and Commands #10478
Merged
Fix DE Icons and Commands #10478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The icon classes were getting overwritten by the strict equality at the end |
abist
approved these changes
May 18, 2020
kburtram
approved these changes
May 18, 2020
|
@aaomidi could you please create a port of this for release/1.18 |
|
Yep just was waiting to merge this in first. |
aaomidi
pushed a commit
that referenced
this pull request
May 18, 2020
* Fixes the DE icons * Fixes the commands
kburtram
pushed a commit
that referenced
this pull request
May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #10443 #10446