-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
open viewlet on showPreview #10474
open viewlet on showPreview #10474
Conversation
Have you verified that the book viewlet isn't capturing focus away from the servers viewlet with this change? There was a bug in the book code before where we were always stealing away focus from the servers viewlet if a books folder was opened in the explorer viewlet. |
To double check - and this still keeps the behavior that when you open ADS it won't always go to the Books viewlet? This was an issue that we fixed that when the books were loaded upon ADS starting they'd cause focus to switch to the viewlet and let's make sure we're not regressing back to that. |
And Cory beat me by a couple seconds 😛 |
Yes I did! And it works, showPreview is only set when user triggers the openBook. |
* open viewlet on shoePreview * on showPreview reveal explorer
This PR fixes #10469