Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open viewlet on showPreview #10474

Merged
merged 2 commits into from
May 18, 2020
Merged

open viewlet on showPreview #10474

merged 2 commits into from
May 18, 2020

Conversation

MaddyDev
Copy link
Contributor

This PR fixes #10469

@corivera
Copy link
Member

corivera commented May 18, 2020

Have you verified that the book viewlet isn't capturing focus away from the servers viewlet with this change? There was a bug in the book code before where we were always stealing away focus from the servers viewlet if a books folder was opened in the explorer viewlet.

@Charles-Gagnon
Copy link
Contributor

To double check - and this still keeps the behavior that when you open ADS it won't always go to the Books viewlet? This was an issue that we fixed that when the books were loaded upon ADS starting they'd cause focus to switch to the viewlet and let's make sure we're not regressing back to that.

@Charles-Gagnon
Copy link
Contributor

And Cory beat me by a couple seconds 😛

@MaddyDev
Copy link
Contributor Author

Have you verified that the book viewlet isn't capturing focus away from the servers viewlet with this change? There was a bug in the book code before where we were always stealing away focus from the servers viewlet if a books folder was opened in the explorer viewlet.

Yes I did! And it works, showPreview is only set when user triggers the openBook.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 33.929% when pulling 075f68b on fix/focusViewletOnOpen into 12ee132 on master.

@MaddyDev MaddyDev merged commit e46521c into master May 18, 2020
@MaddyDev MaddyDev deleted the fix/focusViewletOnOpen branch May 18, 2020 20:47
MaddyDev added a commit that referenced this pull request May 19, 2020
* open viewlet on shoePreview

* on showPreview reveal explorer
kburtram pushed a commit that referenced this pull request May 19, 2020
* open viewlet on shoePreview

* on showPreview reveal explorer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opening the TSG book is not focusing the booksviewlet with the book
4 participants