Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ML- Fixed the issue with wrong title in predict page #10467

Merged
merged 7 commits into from
May 19, 2020
Merged

Conversation

llali
Copy link
Member

@llali llali commented May 16, 2020

This PR fixes #10466

@llali llali requested review from udeeshagautam and MsSQLGirl May 16, 2020 01:40
@coveralls
Copy link

coveralls commented May 16, 2020

Coverage Status

Coverage increased (+0.004%) to 33.879% when pulling 0681b97 on llali/ml-bugfixing2 into 283ffd7 on master.

@@ -40,6 +40,7 @@ export class PredictWizard extends ModelViewBase {
* Opens a dialog to manage packages used by notebooks.
*/
public async open(): Promise<void> {
this.modelSourceType = ModelSourceType.RegisteredModels;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good but not sure how this fixes the script issue? was that because of missing t use registered models?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah sorry wrong issue mapped.

@llali llali merged commit f73d81b into master May 19, 2020
@llali llali deleted the llali/ml-bugfixing2 branch May 19, 2020 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ML - Make Predictions Step 2 title
3 participants