Modify git edits #10442
Merged
Modify git edits #10442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kburtram
approved these changes
May 15, 2020
|
|
||
|
|
||
| // @ts-expect-error | ||
| async function checkGitVersion(info: IGit): Promise<void> { |
There was a problem hiding this comment.
are we going to start getting the legacy git warning now? Ideally we won't since it's not relevant to a lot of ADS customers and we already have too many notifications on 1st launch.
There was a problem hiding this comment.
I commented how the part that calls this function. https://github.com/microsoft/azuredatastudio/pull/10442/files#diff-7c73a37cb94032abbc15f0dc33c88469R81
anthonydresser
pushed a commit
that referenced
this pull request
May 15, 2020
kburtram
pushed a commit
that referenced
this pull request
May 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #10334