Notebook model ready sooner (#10420) #10441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kburtram
approved these changes
May 15, 2020
There was a problem hiding this comment.
Looks good to me. @chlafreniere please let me know if you hit any issues porting your fix.
aaomidi
reviewed
May 15, 2020
| @@ -42,6 +42,7 @@ export class NotebookEditorModel extends EditorModel { | |||
| private _notebookTextFileModel: NotebookTextFileModel; | |||
| private readonly _onDidChangeDirty: Emitter<void> = this._register(new Emitter<void>()); | |||
| private _lastEditFullReplacement: boolean; | |||
| private _isFirstKernelChange: boolean = true; | |||
There was a problem hiding this comment.
For future I would put this behind a guard so it can't be set to true after it's set to false as a defensive measure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports #10416 to release.